attribute should not require a connection is established
#2138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow rails/rails#41302. rails/rails#41302 changed the behaviour `adapter_name_from`. Below are the differences based on that implementation. ## Before ```console Test3Employee.connection.adapter_name.downcase.to_sym # => :oracleenhanced ``` ## After ```console Test3Employee.connection_db_config.adapter.to_sym # => :oracle_enhanced ``` This PR conforms to the new behavior of `adapter_name_from` and fixes the following build error. ```console % bundle exec rspec (snip) rspec ./spec/active_record/oracle_enhanced/type/boolean_spec.rb:116 # OracleEnhancedAdapter boolean type detection based on string column types and names / VARCHAR2 boolean values from ActiveRecord model should return boolean value from VARCHAR2 boolean column if emulate_booleans_from_strings is true rspec ./spec/active_record/oracle_enhanced/type/boolean_spec.rb:141 # OracleEnhancedAdapter boolean type detection based on string column types and names / VARCHAR2 boolean values from ActiveRecord model should return boolean value from VARCHAR2 boolean column if attribute is set to :boolean ``` https://github.com/rsim/oracle-enhanced/runs/1822500989
|
Would you rebase this pull request based on the latest master branch? |
|
Please ignore my previous comment because I was thinking #2136 has been merged to master but it has not been yet. |
|
Yup. I've cherry-picked the commit to #2136 and I will close this PR. Thank you for your review. |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow rails/rails#41302.
rails/rails#41302 changed the behaviour
adapter_name_from.Below are the differences based on that implementation.
Before
After
This PR conforms to the new behavior of
adapter_name_fromandfixes the following build error.
https://github.com/rsim/oracle-enhanced/runs/1822500989