attribute
should not require a connection is established
#2138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow rails/rails#41302.
rails/rails#41302 changed the behaviour
adapter_name_from
.Below are the differences based on that implementation.
Before
After
This PR conforms to the new behavior of
adapter_name_from
andfixes the following build error.
https://github.com/rsim/oracle-enhanced/runs/1822500989