Rails 6.2 is now Rails 7.0 #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will apply rails/rails@6487836 to this PR and investigate failure spec ASAP. |
|
It looks like JRuby 9.4 is planned to support Ruby 2.7. Then in the meantime, we may need to disable CI against all of the JRuby versions. |
Rails 7.0 requires Ruby 2.7 or higeher. CI pending the following matrix until JRuby 9.4 that supports Ruby 2.7 will be released. jruby/jruby#6464
koic
force-pushed
the
rails_62_is_now_rails_70
branch
from
4050ccb
to
3d11748
Compare
|
Thanks for the information. I disabled JRuby CI matrix. |
|
MRI 2.7 and MRI 3.0 build errors are not related from Rails 6.2 to Rails 7.0. They will be resolved by #2138. |
Follow rails/rails#41302. rails/rails#41302 changed the behaviour `adapter_name_from`. Below are the differences based on that implementation. ## Before ```console Test3Employee.connection.adapter_name.downcase.to_sym # => :oracleenhanced ``` ## After ```console Test3Employee.connection_db_config.adapter.to_sym # => :oracle_enhanced ``` This PR conforms to the new behavior of `adapter_name_from` and fixes the following build error. ```console % bundle exec rspec (snip) rspec ./spec/active_record/oracle_enhanced/type/boolean_spec.rb:116 # OracleEnhancedAdapter boolean type detection based on string column types and names / VARCHAR2 boolean values from ActiveRecord model should return boolean value from VARCHAR2 boolean column if emulate_booleans_from_strings is true rspec ./spec/active_record/oracle_enhanced/type/boolean_spec.rb:141 # OracleEnhancedAdapter boolean type detection based on string column types and names / VARCHAR2 boolean values from ActiveRecord model should return boolean value from VARCHAR2 boolean column if attribute is set to :boolean ``` https://github.com/rsim/oracle-enhanced/runs/1822500989
|
CI failures happen at bug report templates, which needs this pull request merged anyway. |
|
The master branch build has been successful! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow rails/rails@1b455e2.