Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move write_lobs under OracleEnhanced::DatabaseStatements module #1546

Merged
merged 1 commit into from
Oct 20, 2017
Merged

Move write_lobs under OracleEnhanced::DatabaseStatements module #1546

merged 1 commit into from
Oct 20, 2017

Conversation

yahonda
Copy link
Collaborator

@yahonda yahonda commented Oct 20, 2017

write_lobs called from insert_fixture
then it should be better to be managed under the same module.

@yahonda
Move write_lobs under OracleEnhanced::DatabaseStatements module
8d32fd3 
`write_lobs` called from `insert_fixture`
then it should be better to be managed under the same module.
@yahonda yahonda merged commit 9c27717 into rsim:master Oct 20, 2017
@yahonda yahonda deleted the move_write_lobs branch October 20, 2017 01:09
@koic koic mentioned this pull request Sep 24, 2019
Closed
koic added a commit to koic/oracle-enhanced that referenced this pull request Dec 18, 2019
@koic
Fix an error when writing lobs
b30a361 
### Summary

Fixes rsim#1932.

This PR fixes an error when writing lobs.
This error seems to be caused by rsim#1546. Rails 5.2 and 6.0 has been targeted.

### Other Information

rsim#1932 discusses backporting to Rails 5.2 and Rails 6.0.
@koic koic mentioned this pull request Dec 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yahonda