undefined local variable or method `sql' for #<ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter:0x3ac701ca>

[jlahtinen]

oracle-enhanced/lib/active_record/connection_adapters/oracle_enhanced/database_statements.rb

Line 259 in 1384ca0

raise ActiveRecord::RecordNotFound, "statement #{sql} returned no rows"

[koic]

Thanks for the reporting. Could you write a reproduce script using the following address?
https://github.com/rsim/oracle-enhanced/blob/master/guides/bug_report_templates/active_record_gem.rb

[jlahtinen]

script: https://gist.github.com/jlahtinen/1c71cb2dccc66fd57e4941d45202b4da

[jlahtinen]

possible fix: https://gist.github.com/jlahtinen/6cd243415d41ea2ba9b8d7031f3312a8

[jlahtinen]

I could make a PR also if really needed. Current master is hard for me to get tests pass although so I prefer not 🙄

[koic]

This error seems to be caused by #1546. Rails 5.2 and 6.0 has been targeted.
@yahonda Will it be backported to 5.2 and 6.0 branches when the master will be fixed?

[yahonda]

Thanks for the investigation.
Actually, it depends how much change is necessary to address this issue to back port or not.

Basically, I prefer to just back port to the latest release version because Oracle enhanced adapter 5.2.0 was released last year and this is the first issue reported after Oracle enhanced adapter 6.0.0 is out.

[koic]

Thanks for your reply.
In fact, I'm using Oracle enhanced adapter 1.8 with Rails 5.1.
I'm glad to have a migration path to Rails 6.0 if backported to Oracle enhanced adapter 5.2 stable branch. The problem is clear and its correction is simple.

[yahonda]

Understood and agreed. please go-ahead to open a pull request to master and backport it to release60 and release52 branches.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[koic]

I will take this issue later.

[yahonda]

Thanks for the update.