Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: iframe input hook (#990) #991

Merged
merged 5 commits into from
Sep 9, 2022
Merged

fix: iframe input hook (#990) #991

merged 5 commits into from
Sep 9, 2022

Conversation

luocongqiu
Copy link
Contributor

No description provided.

Copy link
Member

@YunFeng0817 YunFeng0817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luocongqiu Thanks for your contribution both on the issue and pull request. Your pull request looks great.

packages/rrweb/src/record/observer.ts Show resolved Hide resolved
@YunFeng0817 YunFeng0817 linked an issue Sep 8, 2022 that may be closed by this pull request
1 task
Copy link
Member

@Yuyz0112 Yuyz0112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: input value is not record when in a iframe
4 participants