fix: Iframe replay fails after the second full snapshot #983 #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
YunFeng0817
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
Thanks for your great pull request. I also ran into this problem before. I tried to fixed it on the replayer side. https://github.com/rrweb-io/rrweb/pull/989/files#diff-0d9a03e75eacff8f6be89336b49419b210455c1a81d8f46fae7cea2d83a8f93eR339-R341
It can resolve the error for events recorded with the old version.
Your fix is on the recorder side and it's also very nice.
1 task
|
Thanks! |
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the frame document node root id is undefined after first full snapshot, is the same as id after second full snapshot, then replay fail