bugfix: Sort attributes to make rr_* attributes handled last
#970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rr_dataURL` overwrites `src` attribute, because of this we need to evaluate `rr_dataURL` last so it doesn't accidentally get overwritten again.
Juice10
changed the title
rr_* attributes handled lastrr_* attributes handled last
Juice10
commented
Aug 24, 2022
Yuyz0112
reviewed
Sep 1, 2022
|
Had a chat with @eoghanmurray and @Mark-Fenng, I'm going to do a refactor which eliminates the loop overhead. |
Be a little more strict when it comes attribute types
eoghanmurray
requested changes
Sep 21, 2022
@eoghanmurray I did some performance tests and this one was faster so I ended up going with this |
|
Cool, happy to approve! |
|
@eoghanmurray thanks Eoghan! Yes it was from our chat initially. But it got deleted and then came back again |
YunFeng0817
approved these changes
Sep 22, 2022
Yuyz0112
approved these changes
Sep 26, 2022
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rr_dataURLoverwritessrcattribute, because of this we need to evaluaterr_dataURLlast sosrcdoesn't accidentally get overwritten again.