fix: can't record shadow root's children except the last one #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuyz0112
approved these changes
Sep 7, 2022
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #834 added the ability to record incremental shadow dom mutations. But I found that it has a bug: If a shadow root has more than one child, the recorder can only record the last child and other children are ignored.
In the test case, I added one more child to the shadow root, but generated snapshot of the old version rrweb didn't change at all, which means the recorder did not record that child.
The reason is that all children except the last one of a shadow root are all added to the DoubleLinkedList in the
pushAddfunction because their siblings haven't been added yet. But while resolving these nodes in the next stage, their parentNode is the shadow root that is not in the Mirror so they are all ignored to break out the while loop. This PR adds a check for this situation.