refactor: eliminate eslint errors

.eslintrc.js

@@ -19,5 +19,8 @@ module.exports = {
   plugins: ['@typescript-eslint', 'eslint-plugin-tsdoc'],
   rules: {
     'tsdoc/syntax': 'warn',
+    '@typescript-eslint/unbound-method': 'off',
+    '@typescript-eslint/no-unsafe-member-access': 'off',
+    '@typescript-eslint/restrict-template-expressions': 'off',
   },
 };

packages/rrweb/package.json

@@ -78,7 +78,7 @@
     "@xstate/fsm": "^1.4.0",
     "base64-arraybuffer": "^1.0.1",
     "fflate": "^0.4.4",
-    "mitt": "^1.1.3",
+    "mitt": "^3.0.0",
     "rrdom": "^0.1.2",
     "rrweb-snapshot": "^1.1.14"
   }

packages/rrweb/src/plugins/console/record/error-stack-parser.ts

@@ -27,19 +27,9 @@ export class StackFrame {
   toString() {
     const lineNumber = this.lineNumber || '';
     const columnNumber = this.columnNumber || '';
-    if (this.functionName) {
-      return (
-        this.functionName +
-        ' (' +
-        this.fileName +
-        ':' +
-        lineNumber +
-        ':' +
-        columnNumber +
-        ')'
-      );
-    }
-    return this.fileName + ':' + lineNumber + ':' + columnNumber;
+    if (this.functionName)
+      return `${this.functionName} (${this.fileName}:${lineNumber}:${columnNumber})`;
+    return `${this.fileName}:${lineNumber}:${columnNumber}`;
   }
 }
 
@@ -55,18 +45,17 @@ const SAFARI_NATIVE_CODE_REGEXP = /^(eval@)?(\[native code])?$/;
 export const ErrorStackParser = {
   /**
    * Given an Error object, extract the most information from it.
-   *
-   * @param {Error} error object
-   * @return {Array} of StackFrames
    */
   parse: function (error: Error): StackFrame[] {
     // https://github.com/rrweb-io/rrweb/issues/782
     if (!error) {
       return [];
     }
     if (
+      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
       // @ts-ignore
       typeof error.stacktrace !== 'undefined' ||
+      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
       // @ts-ignore
       typeof error['opera#sourceloc'] !== 'undefined'
     ) {

packages/rrweb/src/plugins/console/record/index.ts

@@ -59,27 +59,6 @@ export type LogData = {
 
 type logCallback = (p: LogData) => void;
 
-export type LogLevel =
-  | 'assert'
-  | 'clear'
-  | 'count'
-  | 'countReset'
-  | 'debug'
-  | 'dir'
-  | 'dirxml'
-  | 'error'
-  | 'group'
-  | 'groupCollapsed'
-  | 'groupEnd'
-  | 'info'
-  | 'log'
-  | 'table'
-  | 'time'
-  | 'timeEnd'
-  | 'timeLog'
-  | 'trace'
-  | 'warn';
-
 /* fork from interface Console */
 // all kinds of console functions
 export type Logger = {
@@ -104,13 +83,24 @@ export type Logger = {
   warn?: typeof console.warn;
 };
 
+export type LogLevel = keyof Logger;
+
 function initLogObserver(
   cb: logCallback,
   win: IWindow, // top window or in an iframe
-  logOptions: LogRecordOptions,
+  options: LogRecordOptions,
 ): listenerHandler {
+  const logOptions = (options
+    ? Object.assign({}, defaultLogOptions, options)
+    : defaultLogOptions) as {
+    level: LogLevel[];
+    lengthThreshold: number;
+    stringifyOptions?: StringifyOptions;
+    logger: Logger | 'console';
+  };
   const loggerType = logOptions.logger;
   if (!loggerType) {
+    // eslint-disable-next-line @typescript-eslint/no-empty-function
     return () => {};
   }
   let logger: Logger;
@@ -122,10 +112,11 @@ function initLogObserver(
   let logCount = 0;
   const cancelHandlers: listenerHandler[] = [];
   // add listener to thrown errors
-  if (logOptions.level!.includes('error')) {
+  if (logOptions.level.includes('error')) {
     if (window) {
       const errorHandler = (event: ErrorEvent) => {
-        const { message, error } = event;
+        const message = event.message,
+          error = event.error as Error;
         const trace: string[] = ErrorStackParser.parse(
           error,
         ).map((stackFrame: StackFrame) => stackFrame.toString());
@@ -142,7 +133,7 @@ function initLogObserver(
       });
     }
   }
-  for (const levelType of logOptions.level!) {
+  for (const levelType of logOptions.level) {
     cancelHandlers.push(replace(logger, levelType));
   }
   return () => {
@@ -151,46 +142,51 @@ function initLogObserver(
 
   /**
    * replace the original console function and record logs
-   * @param logger the logger object such as Console
-   * @param level the name of log function to be replaced
+   * @param logger - the logger object such as Console
+   * @param level - the name of log function to be replaced
    */
   function replace(_logger: Logger, level: LogLevel) {
     if (!_logger[level]) {
+      // eslint-disable-next-line @typescript-eslint/no-empty-function
       return () => {};
     }
     // replace the logger.{level}. return a restore function
-    return patch(_logger, level, (original) => {
-      return (...args: Array<unknown>) => {
-        original.apply(this, args);
-        try {
-          const trace = ErrorStackParser.parse(new Error())
-            .map((stackFrame: StackFrame) => stackFrame.toString())
-            .splice(1); // splice(1) to omit the hijacked log function
-          const payload = args.map((s) =>
-            stringify(s, logOptions.stringifyOptions),
-          );
-          logCount++;
-          if (logCount < logOptions.lengthThreshold!) {
-            cb({
-              level,
-              trace,
-              payload,
-            });
-          } else if (logCount === logOptions.lengthThreshold) {
-            // notify the user
-            cb({
-              level: 'warn',
-              trace: [],
-              payload: [
-                stringify('The number of log records reached the threshold.'),
-              ],
-            });
+    return patch(
+      _logger,
+      level,
+      (original: (...args: Array<unknown>) => void) => {
+        return (...args: Array<unknown>) => {
+          original.apply(this, args);
+          try {
+            const trace = ErrorStackParser.parse(new Error())
+              .map((stackFrame: StackFrame) => stackFrame.toString())
+              .splice(1); // splice(1) to omit the hijacked log function
+            const payload = args.map((s) =>
+              stringify(s, logOptions.stringifyOptions),
+            );
+            logCount++;
+            if (logCount < logOptions.lengthThreshold) {
+              cb({
+                level,
+                trace,
+                payload,
+              });
+            } else if (logCount === logOptions.lengthThreshold) {
+              // notify the user
+              cb({
+                level: 'warn',
+                trace: [],
+                payload: [
+                  stringify('The number of log records reached the threshold.'),
+                ],
+              });
+            }
+          } catch (error) {
+            original('rrweb logger error:', error, ...args);
           }
-        } catch (error) {
-          original('rrweb logger error:', error, ...args);
-        }
-      };
-    });
+        };
+      },
+    );
   }
 }
 
@@ -201,7 +197,5 @@ export const getRecordConsolePlugin: (
 ) => RecordPlugin = (options) => ({
   name: PLUGIN_NAME,
   observer: initLogObserver,
-  options: options
-    ? Object.assign({}, defaultLogOptions, options)
-    : defaultLogOptions,
+  options: options,
 });