Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nested stylesheets should have absolute URLs #1533

Merged
merged 15 commits into from
Jul 25, 2024
Merged

fix: nested stylesheets should have absolute URLs #1533

merged 15 commits into from
Jul 25, 2024

Commits on Jul 16, 2024

  1. Replace relative URLs with absolute URLs when stringifying stylesheets

    @jeffdnguyen
    jeffdnguyen committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    d685bc6 View commit details
    Browse the repository at this point in the history

  2. Add test to show desired behavior for imported stylesheets from seper… 

    …ate directory
    @jeffdnguyen
    jeffdnguyen committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    c6c0ee3 View commit details
    Browse the repository at this point in the history

  3. Add changeset

    @jeffdnguyen
    jeffdnguyen committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    f69e8f3 View commit details
    Browse the repository at this point in the history

  4. Rename absoluteToStylesheet to absolutifyURLs and call it once af… 

    …ter stringifying imported stylesheet
    @jeffdnguyen
    jeffdnguyen committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    27432e2 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Don't create the intermediary array of the spread operator

    @eoghanmurray @jeffdnguyen
    eoghanmurray authored and jeffdnguyen committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    6ca68b8 View commit details
    Browse the repository at this point in the history

  2. Formalize that stringifyRule should expect a sheet href

    @eoghanmurray @jeffdnguyen
    eoghanmurray authored and jeffdnguyen committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    ddebff5 View commit details
    Browse the repository at this point in the history

  3. Ensure a <style> element can also import and gets it's url absolutized

    @eoghanmurray @jeffdnguyen
    eoghanmurray authored and jeffdnguyen committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    04b3fc6 View commit details
    Browse the repository at this point in the history

  4. Apply formatting changes

    @eoghanmurray @jeffdnguyen
    eoghanmurray authored and jeffdnguyen committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    0c0ceb9 View commit details
    Browse the repository at this point in the history

  5. Handle case where non imported stylesheet has relative urls that need… 

    … to be absolutified
    @jeffdnguyen
    jeffdnguyen committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    f4bfd73 View commit details
    Browse the repository at this point in the history

  6. Clarify in test files where jpegs are expected to appear in absolutif… 

    …ied urls
    @jeffdnguyen
    jeffdnguyen committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    72f6a68 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Movee absolutifyURLs call for import rules out of trycatch

    @jeffdnguyen
    jeffdnguyen committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    772f64c View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Add a benchmarking test for stringifyStylesheet

    @eoghanmurray @jeffdnguyen
    eoghanmurray authored and jeffdnguyen committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    8edb9fa View commit details
    Browse the repository at this point in the history

  2. Avoid the duplication on how to fall back

    @eoghanmurray @jeffdnguyen
    eoghanmurray authored and jeffdnguyen committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    e4d1861 View commit details
    Browse the repository at this point in the history

  3. Add explanatory comment

    @eoghanmurray @jeffdnguyen
    eoghanmurray authored and jeffdnguyen committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    74f3758 View commit details
    Browse the repository at this point in the history

  4. Code style: more compact

    @eoghanmurray @jeffdnguyen
    eoghanmurray authored and jeffdnguyen committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    acf1cb9 View commit details
    Browse the repository at this point in the history