fix: pass maskInputFn to snapshot #1490
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lewgordon-amplitude
force-pushed
the
lewgordon/pass-mask-input-fn
branch
2 times, most recently
from
d157537
to
f3cdbb7
Compare
lewgordon-amplitude
force-pushed
the
lewgordon/pass-mask-input-fn
branch
from
f3cdbb7
to
f67cd4a
Compare
|
Thanks @lewgordon-amplitude I'll close this as a duplicate of the other one you mention; I think that one is close to merging, I've just got a few questions on it. |
|
Sounds good, thanks @eoghanmurray |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw the same change proposed in #1386, but not merged. I can't see why the tests were failing. I'd like to help get this through.