Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(genadds) traverse children in reverse order #1398

Closed
wants to merge 1 commit into from
+11 −3
Closed

perf(genadds) traverse children in reverse order #1398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/unlucky-flowers-remember.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'rrweb': patch
---

traverse childNodes in reverse order to match desired serialization order
9 changes: 6 additions & 3 deletions packages/rrweb/src/record/mutation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -728,12 +728,15 @@ export default class MutationBuffer {
// if this node is blocked `serializeNode` will turn it into a placeholder element
// but we have to remove it's children otherwise they will be added as placeholders too
if (!isBlocked(n, this.blockClass, this.blockSelector, false)) {
n.childNodes.forEach((childN) => this.genAdds(childN));
for (let i = n.childNodes.length - 1; i >= 0; --i) {
this.genAdds(n.childNodes[i]);
}
if (hasShadowRoot(n)) {
n.shadowRoot.childNodes.forEach((childN) => {
for (let j = n.shadowRoot.childNodes.length - 1; j >= 0; --j) {
let childN = n.shadowRoot.childNodes[j];
this.processedNodeManager.add(childN, this);
this.genAdds(childN, n);
});
}
}
}
};
Expand Down
Loading