Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serialization and mutation of <textarea> elements #1351

Merged
merged 12 commits into from
Dec 1, 2023

Commits on Nov 28, 2023

  1. Fix serialization and mutation of <textarea> elements taking account …

    …the duality that the value can be set in either the child node, or in the value _parameter_ (not attribute)
    eoghanmurray committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    476af5b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a807888 View commit details
    Browse the repository at this point in the history
  3. Bug fix and regression test for rrweb-io#112

     - this is to fix up 'historical' recordings, as duplicate textarea content should no longer be being created at record time (see previous commit in this PR)
     - new test shows what the snapshot generated by previous versions of rrweb used to look like, hence 'bad'
     - original 0efe23f fix either didn't work or no longer works due to childNodes being appended subsequent to this part of the code
    eoghanmurray committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    cbfc506 View commit details
    Browse the repository at this point in the history
  4. Fix that textarea values were being missed by the masking system if t…

    …he value was recorded as a child node
    
     - I didn't notice that form.html was used in other tests, so lucky that I noticed that those tests also should have the 'pre value' masked out
    eoghanmurray committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    f800b19 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d002630 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4bc169a View commit details
    Browse the repository at this point in the history
  7. Simplify by always storing the textarea value in the .value attribu…

    …te (from it's DOM property) and not as a childNode. It should still be rebuilt as a childNode rather than a property
    eoghanmurray committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    69c9aa3 View commit details
    Browse the repository at this point in the history
  8. replaceChildNodes is not yet available in RRDom (this replacement cod…

    …e was extremely painful to get right from a typings point of view)
    eoghanmurray committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    ee4aaac View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    71203c7 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Configuration menu
    Copy the full SHA
    e9b0318 View commit details
    Browse the repository at this point in the history
  2. Improvements to test documentation; with Justin's help for better com…

    …prehension of why we are doing things this way
    eoghanmurray committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    302f855 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9df40e4 View commit details
    Browse the repository at this point in the history