-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix serialization and mutation of <textarea> elements #1351
Commits on Nov 28, 2023
-
Fix serialization and mutation of <textarea> elements taking account …
…the duality that the value can be set in either the child node, or in the value _parameter_ (not attribute)
Configuration menu - View commit details
-
Copy full SHA for 476af5b - Browse repository at this point
Copy the full SHA 476af5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for a807888 - Browse repository at this point
Copy the full SHA a807888View commit details -
Bug fix and regression test for rrweb-io#112
- this is to fix up 'historical' recordings, as duplicate textarea content should no longer be being created at record time (see previous commit in this PR) - new test shows what the snapshot generated by previous versions of rrweb used to look like, hence 'bad' - original 0efe23f fix either didn't work or no longer works due to childNodes being appended subsequent to this part of the code
Configuration menu - View commit details
-
Copy full SHA for cbfc506 - Browse repository at this point
Copy the full SHA cbfc506View commit details -
Fix that textarea values were being missed by the masking system if t…
…he value was recorded as a child node - I didn't notice that form.html was used in other tests, so lucky that I noticed that those tests also should have the 'pre value' masked out
Configuration menu - View commit details
-
Copy full SHA for f800b19 - Browse repository at this point
Copy the full SHA f800b19View commit details -
Configuration menu - View commit details
-
Copy full SHA for d002630 - Browse repository at this point
Copy the full SHA d002630View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bc169a - Browse repository at this point
Copy the full SHA 4bc169aView commit details -
Simplify by always storing the textarea value in the
.value
attribu……te (from it's DOM property) and not as a childNode. It should still be rebuilt as a childNode rather than a property
Configuration menu - View commit details
-
Copy full SHA for 69c9aa3 - Browse repository at this point
Copy the full SHA 69c9aa3View commit details -
replaceChildNodes is not yet available in RRDom (this replacement cod…
…e was extremely painful to get right from a typings point of view)
Configuration menu - View commit details
-
Copy full SHA for ee4aaac - Browse repository at this point
Copy the full SHA ee4aaacView commit details -
Configuration menu - View commit details
-
Copy full SHA for 71203c7 - Browse repository at this point
Copy the full SHA 71203c7View commit details
Commits on Dec 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e9b0318 - Browse repository at this point
Copy the full SHA e9b0318View commit details -
Improvements to test documentation; with Justin's help for better com…
…prehension of why we are doing things this way
Configuration menu - View commit details
-
Copy full SHA for 302f855 - Browse repository at this point
Copy the full SHA 302f855View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9df40e4 - Browse repository at this point
Copy the full SHA 9df40e4View commit details