Pointer type fixups #1201
Pointer type fixups #1201
Conversation
🦋 Changeset detectedLatest commit: 4939c00 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
… ended up as a TouchEvent instead of an individual Touch object I think
…nterTypes.Mouse` is expected
eoghanmurray
force-pushed
the
pointerTypeFixups
branch
from
f215c5f
to
777ab9a
Compare
… where a subsequent click would be picked up as a touch (see `thisEventKey` change)
eoghanmurray
force-pushed
the
pointerTypeFixups
branch
from
2c94879
to
004d29b
Compare
| @@ -1847,7 +2135,8 @@ exports[`record integration tests can record form interactions 1`] = ` | |||
| \\"data\\": { | |||
| \\"source\\": 2, | |||
| \\"type\\": 1, | |||
| \\"id\\": 27 | |||
| \\"id\\": 27, | |||
| \\"pointerType\\": 0 | |||
There was a problem hiding this comment.
I'm wondering if we can hide this property by default if the pointer type is mouse.
On the one hand, it can keep most of the data unchanged. On the other hand, most data is triggered by mouse so it can help reduce event size.
There was a problem hiding this comment.
Note: I've merged the pull request as this is a fixup for #1129 which is already merged
There was a problem hiding this comment.
hide this property by default if the pointer type is mouse
I thought of that and am still open to it, some considerations:
- it's also possible (older browsers I guess) that the PointerType info missing, in which case it will be absent (if we went with your suggestion then we could add a
PointerTypes.Unknownfor this case) - we don't tend to do this for other events ... for example at Statcounter I measured the most common fields/values and by far the worst offender in terms of space was Mutations, so we stripped out the data.source and empty attributes/removes/adds/texts on those for the biggest win. TouchUp/Down/MouseUp/Down/Click events are hardly as common as scroll events etc.
There was a problem hiding this comment.
I guess I could remove pointerType from MouseDown/MouseUp/TouchDown/TouchUp as these are implicit, have done so in a new PR: #1206
There was a problem hiding this comment.
After #1206 the pointerType is only on Click events .... I'm also thinking that "most data is triggered by mouse" is an incorrect assumption, as 60% of web browsing is from mobile devices:
https://gs.statcounter.com/platform-market-share/desktop-mobile-tablet
These should have been part of #1129 as I didn't realize the tests were failing