Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set finished=false in goto instead of handleProgressClick #1198

Merged

Commits on Apr 5, 2023

  1. Reset the finished flag in goto

    If the player finishes a replaying a video the `finished` boolean is set to true. This allows the video to be restarted at the beginning if the controller is toggled again. If a user clicks on the progress bar the `finished` boolean is reset so if the `toggle` API is called it starts at the right place. If a user programatically calls `goto` which is the underlying API that handling the progress click calls the next invocation of `toggle` will start the video at the beginning instead of the proper location.
    charliegracie authored Apr 5, 2023
    Configuration menu
    Copy the full SHA
    c3b7a89 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2023

  1. Configuration menu
    Copy the full SHA
    d18721d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9935e99 View commit details
    Browse the repository at this point in the history