fix: Ensure attributes are lowercased when checking #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: df65bf8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
YunFeng0817
approved these changes
Apr 2, 2023
YunFeng0817
reviewed
Apr 2, 2023
mydea
force-pushed
the
fn/ensure-attribute-transform-case-insenstive
branch
from
96c440d
to
a915eb5
Compare
This was referenced Jun 14, 2023
This was referenced Jul 6, 2023
eoghanmurray
pushed a commit
to eoghanmurray/rrweb
that referenced
this pull request
Jul 27, 2023
* fix: Ensure attributes are lowercased when checking * add changeset * fix to lower case * Apply formatting changes --------- Co-authored-by: mydea <mydea@users.noreply.github.com>
eoghanmurray
pushed a commit
to eoghanmurray/rrweb
that referenced
this pull request
Jul 27, 2023
* fix: Ensure attributes are lowercased when checking * add changeset * fix to lower case * Apply formatting changes --------- Co-authored-by: mydea <mydea@users.noreply.github.com>
eoghanmurray
pushed a commit
to eoghanmurray/rrweb
that referenced
this pull request
Jul 27, 2023
* fix: Ensure attributes are lowercased when checking * add changeset * fix to lower case * Apply formatting changes --------- Co-authored-by: mydea <mydea@users.noreply.github.com>
eoghanmurray
pushed a commit
to eoghanmurray/rrweb
that referenced
this pull request
Aug 3, 2023
* fix: Ensure attributes are lowercased when checking * add changeset * fix to lower case * Apply formatting changes --------- Co-authored-by: mydea <mydea@users.noreply.github.com>
eoghanmurray
pushed a commit
to eoghanmurray/rrweb
that referenced
this pull request
Aug 8, 2023
* fix: Ensure attributes are lowercased when checking * add changeset * fix to lower case * Apply formatting changes --------- Co-authored-by: mydea <mydea@users.noreply.github.com>
eoghanmurray
pushed a commit
to eoghanmurray/rrweb
that referenced
this pull request
Aug 8, 2023
* fix: Ensure attributes are lowercased when checking * add changeset * fix to lower case * Apply formatting changes --------- Co-authored-by: mydea <mydea@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently not enforced, and could lead to bugs.
I tried to add a test but it seems that
absoluteToDoc()always returns''in the tests (for whatever reason), making this rather hard to test. Happy about any pointers how to test this nicely!