fix: isCheckout is not included in fullsnapshot event #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f918c91 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Juice10
approved these changes
Feb 17, 2023
This was referenced Jul 6, 2023
This was referenced Dec 8, 2023
billyvg
added a commit
to getsentry/rrweb
that referenced
this pull request
Dec 11, 2023
…io#1141)" (#139) This reverts commit 3416c3a. From [my comment here](rrweb-io#1242 (comment)) > I only used translate on the OP but if I understand correctly, when we call `takeFullSnapshot(true)`, we will receive two distinct events with the `isCheckout` arg as `true`. Looking at the blame this is due to rrweb-io#1141. > If you use `checkoutEvery...` and rely on `isCheckout` to reset existing events, this means that the [`Meta` event](https://github.com/rrweb-io/rrweb/blob/master/packages/rrweb/src/record/index.ts#L352-L362) will be lost because [the `FullSnapshot`](https://github.com/rrweb-io/rrweb/blob/master/packages/rrweb/src/record/index.ts#L408-L417) occurs afterwards, and `isCheckout` is true for both events. Losing the `Meta` event means that the replayer will be unable to set its dimensions, making the replay look broken.
billyvg
added a commit
to getsentry/rrweb
that referenced
this pull request
Apr 26, 2024
…io#1141)" (#139) This reverts commit 3416c3a. From [my comment here](rrweb-io#1242 (comment)) > I only used translate on the OP but if I understand correctly, when we call `takeFullSnapshot(true)`, we will receive two distinct events with the `isCheckout` arg as `true`. Looking at the blame this is due to > If you use `checkoutEvery...` and rely on `isCheckout` to reset existing events, this means that the [`Meta` event](https://github.com/rrweb-io/rrweb/blob/master/packages/rrweb/src/record/index.ts#L352-L362) will be lost because [the `FullSnapshot`](https://github.com/rrweb-io/rrweb/blob/master/packages/rrweb/src/record/index.ts#L408-L417) occurs afterwards, and `isCheckout` is true for both events. Losing the `Meta` event means that the replayer will be unable to set its dimensions, making the replay look broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug
When taking a fullsnapshot with the option
isCheckout, the property is not included in the fullsnapshot event. I guess this property is important for a lot of use cases.