[console-plugin] Feat: Record unhandledrejection event
#1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YunFeng0817
requested changes
Feb 2, 2023
jlalmes
force-pushed
the
feat/console-plugin/add-unhandledrejection-handler
branch
from
e24d463
to
69484f4
Compare
YunFeng0817
reviewed
Feb 2, 2023
There was a problem hiding this comment.
I made some changes in another branch https://github.com/rrweb-io/rrweb/commits/jlalmes-feat/console-plugin/add-unhandledrejection-handler. Could you please take a look at them?
commit 1 :
change the window object to the passed in 'win'. I just noticed these problems in the old version. I'm trying to fix them in the PR by the way.
commit 2
improve serialized error messages
…d-unhandledrejection-handler' into feat/console-plugin/add-unhandledrejection-handler
|
@Mark-Fenng both of these look good to me, I have merged your commits into this branch. 👍 |
YunFeng0817
approved these changes
Feb 2, 2023
|
Thank you! I will merge this if no more people review this by the end of this week. |
This was referenced Feb 12, 2023
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.mozilla.org/en-US/docs/Web/API/Window/unhandledrejection_event