Handle errors when observing iframes #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
force-pushed
the
handle-errors-observe-iframe
branch
from
71972e7
to
bb830f7
Compare
Juice10
approved these changes
Dec 2, 2022
|
I think the failing test is not related to this PR? Could you re-run it? |
billyvg
pushed a commit
to getsentry/rrweb
that referenced
this pull request
Jan 10, 2023
This was referenced Jan 11, 2023
This was referenced Feb 12, 2023
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, any errors in setting up the observers etc. are caught and logged out via
console.warn. However, when the setup is done for any iframes, they are not caught. This can lead to errors popping up for users when e.g. some iframe have a weird setup.This PR ensures the handling is the same for setting up observers in iframes.
Closes #1057