Fix: shadow dom bugs #1049
Merged
Fix: shadow dom bugs #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When moving an element containing shadow dom When adding an element to shadow dom before its attached to the dom
…nto shadow-dom-bugs
Juice10
commented
Nov 11, 2022
Juice10
commented
Nov 11, 2022
1 task
YunFeng0817
reviewed
Jan 9, 2023
YunFeng0817
approved these changes
Jan 10, 2023
This was referenced Jan 11, 2023
Vadman97
added a commit
to highlight/highlight
that referenced
this pull request
Jan 11, 2023
## Summary Bring in rrweb-io/rrweb#1049 to fix shadow dom recording bugs. Related PRs: * highlight/docs#32 * highlight/highlight-javascript#9 * highlight/rrweb#100 ## How did you test this change? Local deploy on /1/buttons shadow dom example. ## Are there any deployment considerations? New version 5.2.2.
|
@Mark-Fenng @Juice10 |
|
@bhavitsharma could you create a separate issue for this including a test case and/or example recording where this is going wrong? Looking at the requestAnimationFrame code, it shouldn’t impact any scroll or click events. |
This was referenced Feb 12, 2023
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a number of shadow dom bugs included bugs related to moving shadow dom parents, and attaching elements to a shadow dom that hasn't been added to a page yet.