Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support media playbackRate #1000

Merged
merged 1 commit into from
Sep 15, 2022
Merged

feat: support media playbackRate #1000

merged 1 commit into from
Sep 15, 2022

Conversation

wfk007
Copy link
Contributor

@wfk007 wfk007 commented Sep 15, 2022

add support for media playbackRate change

YunFeng0817
YunFeng0817 reviewed Sep 15, 2022
View reviewed changes
Copy link
Member

@YunFeng0817 YunFeng0817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All code looks good. To pass the prettier check CI, you may need to rebase the branch with the latest main branch and fix the format problem in observer.ts as well.

packages/rrdom/src/document.ts Show resolved Hide resolved
packages/rrdom/src/diff.ts Show resolved Hide resolved
@Yuyz0112 Yuyz0112 merged commit ce6019d into rrweb-io:master Sep 15, 2022
@Juice10 Juice10 added the 2.0 label Dec 1, 2022
This was referenced Jul 6, 2023
Closed
Closed
Closed
@billyvg billyvg mentioned this pull request Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yuyz0112 Yuyz0112 Yuyz0112 approved these changes

@YunFeng0817 YunFeng0817 YunFeng0817 approved these changes

Assignees
No one assigned
Labels
2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wfk007 @Yuyz0112 @YunFeng0817 @Juice10