Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: text & input masking enhancements #1096

Open
1 task done
mdellanoce opened this issue Jan 17, 2023 · 0 comments · May be fixed by #1097
Open
1 task done

[Feature Request]: text & input masking enhancements #1096

mdellanoce opened this issue Jan 17, 2023 · 0 comments · May be fixed by #1097
Labels
feature request Things want to be added has PR already has pull request for it

Comments

@mdellanoce
Copy link
Contributor

Preflight Checklist

  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

What package is this feature request for?

rrweb

Problem Description

I'm looking to make enhancements to text & input masking (PR to follow, for your consideration). My team is getting ready for a rrweb deployment and we'd like to offer "privacy by default" to avoid collecting sensitive information. My understanding is that the current way to accomplish this is maskTextSelector: '*', however, we would also like to offer the ability to unmask portions of the page that the customer deems safe.

Proposed Solution

  • add maskAllText option, mirroring the naming of maskAllInputs
  • add unmaskTextSelector and unmaskTextClass to selectively unmask certain areas.
  • inputs respect text masking options in addition to input masking options for finer control over which inputs are masked or unmasked.

Alternatives Considered

I'm not aware of any current solutions for unmasking content with rrweb.

Additional Information

No response
@mdellanoce mdellanoce added the feature request Things want to be added label Jan 17, 2023
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Jan 17, 2023
@mdellanoce
support for mask all and unmask by selector and class rrweb-io#1096
a4f52c5
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Jan 17, 2023
@mdellanoce
apply text mask settings to inputs rrweb-io#1096
eae89e8
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Jan 17, 2023
@mdellanoce
support for mask all and unmask by selector and class rrweb-io#1096
ccb511a
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Jan 17, 2023
@mdellanoce
apply text mask settings to inputs rrweb-io#1096
c4980bc
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Feb 1, 2023
@mdellanoce
support for mask all and unmask by selector and class rrweb-io#1096
eac4a1f
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Feb 1, 2023
@mdellanoce
apply text mask settings to inputs rrweb-io#1096
96fb991
@YunFeng0817 YunFeng0817 added the has PR already has pull request for it label Feb 3, 2023
@YunFeng0817 YunFeng0817 linked a pull request Feb 6, 2023 that will close this issue
text masking settings apply to inputs #1097
Open
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Feb 13, 2023
@mdellanoce
remove default for unmaskTextClass rrweb-io#1096
59ed77f
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Feb 13, 2023
@mdellanoce
skip mask distance if unmask is not found and maskAllText is true rrw…
7173936 
…eb-io#1096
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Feb 13, 2023
@mdellanoce
support for mask all and unmask by selector and class rrweb-io#1096
d9c20c2
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Feb 13, 2023
@mdellanoce
apply text mask settings to inputs rrweb-io#1096
e958303
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Feb 13, 2023
@mdellanoce
remove default for unmaskTextClass rrweb-io#1096
84ecbf2
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Feb 13, 2023
@mdellanoce
skip mask distance if unmask is not found and maskAllText is true rrw…
f55c4a2 
…eb-io#1096
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Feb 13, 2023
@mdellanoce
remove default for unmaskTextClass rrweb-io#1096
ed3ea49
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Feb 13, 2023
@mdellanoce
skip mask distance if unmask is not found and maskAllText is true rrw…
0ebbc5e 
…eb-io#1096
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Mar 14, 2023
@mdellanoce
support for mask all and unmask by selector and class rrweb-io#1096
551cf33
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Mar 14, 2023
@mdellanoce
apply text mask settings to inputs rrweb-io#1096
68323b1
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Mar 14, 2023
@mdellanoce
remove default for unmaskTextClass rrweb-io#1096
58dffc1
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Mar 14, 2023
@mdellanoce
skip mask distance if unmask is not found and maskAllText is true rrw…
519240f 
…eb-io#1096
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Apr 6, 2023
@mdellanoce
support for mask all and unmask by selector and class rrweb-io#1096
f355dd3
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Apr 6, 2023
@mdellanoce
apply text mask settings to inputs rrweb-io#1096
7c3f51c
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Apr 6, 2023
@mdellanoce
remove default for unmaskTextClass rrweb-io#1096
ab437ea
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Apr 6, 2023
@mdellanoce
skip mask distance if unmask is not found and maskAllText is true rrw…
4dbfa74 
…eb-io#1096
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Apr 10, 2023
@mdellanoce
support for mask all and unmask by selector and class rrweb-io#1096
5b92a35
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Apr 10, 2023
@mdellanoce
apply text mask settings to inputs rrweb-io#1096
476d901
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Apr 10, 2023
@mdellanoce
remove default for unmaskTextClass rrweb-io#1096
3379659
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Apr 10, 2023
@mdellanoce
skip mask distance if unmask is not found and maskAllText is true rrw…
7d89c72 
…eb-io#1096
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Apr 10, 2023
@mdellanoce
optimize mask/unmask rule matching rrweb-io#1096
4cc3c1f
billyvg pushed a commit to getsentry/rrweb that referenced this issue Aug 30, 2023
@mdellanoce @billyvg
add benchmarks for text masking rrweb-io#1096
8239b53
@billyvg billyvg mentioned this issue Sep 20, 2023
Merged
billyvg added a commit to getsentry/rrweb that referenced this issue Sep 21, 2023
@billyvg @mdellanoce
@YunFeng0817 @mydea @Lms24
feat: Upgrade to rrweb2 (#107)
5f5c00d 
Brings this library up to date w/ upstream. Includes additional commits for enhanced privacy and Sentry release workflows.

Cherry picks include the following upstream PRs:

* rrweb-io#1096
* rrweb-io#1155
* rrweb-io#1257
* rrweb-io#1262


Cherry picks from getsentry fork:
* #70
* #103
*
064d8c4
*
e274f88
*
cffefa2
* #20

---------

Co-authored-by: Michael Dellanoce <mdellanoce@pendo.io>
Co-authored-by: mdellanoce <mdellanoce@users.noreply.github.com>
Co-authored-by: Yun Feng <yun.feng0817@gmail.com>
Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
@benjackwhite benjackwhite mentioned this issue Sep 26, 2023
Merged
billyvg added a commit to getsentry/rrweb that referenced this issue Oct 20, 2023
@billyvg @mdellanoce
@YunFeng0817 @mydea @Lms24
feat: Upgrade to rrweb2 (#107)
1f2b55f 
Brings this library up to date w/ upstream. Includes additional commits for enhanced privacy and Sentry release workflows.

Cherry picks include the following upstream PRs:

* rrweb-io#1096
* rrweb-io#1155
* rrweb-io#1257
* rrweb-io#1262

Cherry picks from getsentry fork:
* #70
* #103
*
064d8c4
*
e274f88
*
cffefa2
* #20

---------

Co-authored-by: Michael Dellanoce <mdellanoce@pendo.io>
Co-authored-by: mdellanoce <mdellanoce@users.noreply.github.com>
Co-authored-by: Yun Feng <yun.feng0817@gmail.com>
Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Oct 27, 2023
@mdellanoce
support for mask all and unmask by selector and class rrweb-io#1096
3bfa800
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Oct 27, 2023
@mdellanoce
apply text mask settings to inputs rrweb-io#1096
37c9638
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Oct 27, 2023
@mdellanoce
remove default for unmaskTextClass rrweb-io#1096
ab03487
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Oct 27, 2023
@mdellanoce
skip mask distance if unmask is not found and maskAllText is true rrw…
599cc89 
…eb-io#1096
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Oct 27, 2023
@mdellanoce
optimize mask/unmask rule matching rrweb-io#1096
17b5e67
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Oct 27, 2023
@mdellanoce
optimization for when maskAllText is false rrweb-io#1096
8f104a7
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Oct 27, 2023
@mdellanoce
add benchmarks for text masking rrweb-io#1096
1f387e6
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Nov 7, 2023
@mdellanoce
support for mask all and unmask by selector and class rrweb-io#1096
c7dc08a
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Nov 7, 2023
@mdellanoce
apply text mask settings to inputs rrweb-io#1096
ddb4d8c
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Nov 7, 2023
@mdellanoce
remove default for unmaskTextClass rrweb-io#1096
12cf430
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Nov 7, 2023
@mdellanoce
skip mask distance if unmask is not found and maskAllText is true rrw…
bb92a19 
…eb-io#1096
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Nov 7, 2023
@mdellanoce
optimize mask/unmask rule matching rrweb-io#1096
2e37a31
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Nov 7, 2023
@mdellanoce
optimization for when maskAllText is false rrweb-io#1096
08ac4b0
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Nov 7, 2023
@mdellanoce
add benchmarks for text masking rrweb-io#1096
e9c70a2
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Dec 7, 2023
@mdellanoce
apply text mask settings to inputs rrweb-io#1096
fe88c35
mdellanoce added a commit to pendo-io/rrweb that referenced this issue Dec 12, 2023
@mdellanoce
apply text mask settings to inputs rrweb-io#1096
a2e7ddd
guntherjh pushed a commit to pendo-io/rrweb that referenced this issue Feb 28, 2024
@mdellanoce @guntherjh
apply text mask settings to inputs rrweb-io#1096
d526dc5
jaj1014 pushed a commit to pendo-io/rrweb that referenced this issue Apr 22, 2024
@mdellanoce @jaj1014
apply text mask settings to inputs rrweb-io#1096
bbf38bf
dkindel pushed a commit to pendo-io/rrweb that referenced this issue Apr 22, 2024
@mdellanoce @dkindel
apply text mask settings to inputs rrweb-io#1096
b9a0726
billyvg added a commit to getsentry/rrweb that referenced this issue Apr 26, 2024
@billyvg @mdellanoce
@YunFeng0817 @mydea @Lms24
feat: Upgrade to rrweb2 (#107)
63723ac 
Brings this library up to date w/ upstream. Includes additional commits for enhanced privacy and Sentry release workflows.

Cherry picks include the following upstream PRs:

* rrweb-io#1096
* rrweb-io#1155
* rrweb-io#1257
* rrweb-io#1262

Cherry picks from getsentry fork:
* #70
* #103
*
064d8c4
*
e274f88
*
cffefa2
* #20

---------

Co-authored-by: Michael Dellanoce <mdellanoce@pendo.io>
Co-authored-by: mdellanoce <mdellanoce@users.noreply.github.com>
Co-authored-by: Yun Feng <yun.feng0817@gmail.com>
Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
jaj1014 pushed a commit to pendo-io/rrweb that referenced this issue Apr 30, 2024
@mdellanoce @jaj1014
apply text mask settings to inputs rrweb-io#1096
938b884
colingm pushed a commit to pendo-io/rrweb that referenced this issue May 1, 2024
@mdellanoce @colingm
apply text mask settings to inputs rrweb-io#1096
fc9b27b
colingm pushed a commit to pendo-io/rrweb that referenced this issue May 1, 2024
@mdellanoce @colingm
apply text mask settings to inputs rrweb-io#1096
b1a1922
jeffdnguyen pushed a commit to pendo-io/rrweb that referenced this issue Jul 29, 2024
@mdellanoce @jeffdnguyen
apply text mask settings to inputs rrweb-io#1096
2ca12d1
jeffdnguyen pushed a commit to pendo-io/rrweb that referenced this issue Jul 29, 2024
@mdellanoce @jeffdnguyen
apply text mask settings to inputs rrweb-io#1096
907f97d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Things want to be added has PR already has pull request for it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

text masking settings apply to inputs pendo-io/rrweb
2 participants
@mdellanoce @YunFeng0817