Fix mutation edge case when blocked class gets unblocked (#867)

* Fix mutation edge case when blocked class gets unblocked * Add integration test * Update isSerialized logic
rrweb-io · Apr 15, 2022 · 93fec1f · 93fec1f
1 parent e4f680e
commit 93fec1f
Show file tree

Hide file tree

Showing 5 changed files with 854 additions and 1 deletion.
diff --git a/packages/rrweb/src/record/mutation.ts b/packages/rrweb/src/record/mutation.ts
@@ -22,6 +22,7 @@ import {
   isBlocked,
   isAncestorRemoved,
   isIgnored,
+  isSerialized,
   hasShadowRoot,
   isSerializedIframe,
 } from '../utils';
@@ -525,7 +526,8 @@ export default class MutationBuffer {
             : this.mirror.getId(m.target);
           if (
             isBlocked(m.target, this.blockClass) ||
-            isIgnored(n, this.mirror)
+            isIgnored(n, this.mirror) ||
+            !isSerialized(n, this.mirror)
           ) {
             return;
           }

diff --git a/packages/rrweb/src/utils.ts b/packages/rrweb/src/utils.ts
@@ -213,6 +213,10 @@ export function isBlocked(node: Node | null, blockClass: blockClass): boolean {
   return isBlocked(node.parentNode, blockClass);
 }
 
+export function isSerialized(n: Node, mirror: Mirror): boolean {
+  return mirror.getId(n) !== -1;
+}
+
 export function isIgnored(n: Node, mirror: Mirror): boolean {
   // The main part of the slimDOM check happens in
   // rrweb-snapshot::serializeNodeWithId