Fix false positive for UnsafeToAtom

Refs #1148
rrrene · Sep 23, 2024 · 175d0ab · 175d0ab
1 parent 3a6a0c0
commit 175d0ab
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/lib/credo/check/warning/unsafe_to_atom.ex b/lib/credo/check/warning/unsafe_to_atom.ex
@@ -52,6 +52,11 @@ defmodule Credo.Check.Warning.UnsafeToAtom do
     {nil, issues}
   end
 
+  # module.unquote(:"some_atom")
+  defp traverse({{:., _, [_, :unquote]}, _, [_ | _] = _args}, issues, _) do
+    {nil, issues}
+  end
+
   defp traverse(
          {:|>, _meta1, [_lhs, {{:., _meta2, call}, meta, args}]} = ast,
          issues,

diff --git a/test/credo/check/warning/unsafe_to_atom_test.exs b/test/credo/check/warning/unsafe_to_atom_test.exs
@@ -35,6 +35,8 @@ defmodule Credo.Check.Warning.UnsafeToAtomTest do
 
       def convert_erlang_binary(parameter) do
         :erlang.binary_to_existing_atom(parameter, :utf8)
+
+        unquote(context).unquote(:"get_#{type}_by")(id: id)
       end
 
       for n <- 1..4 do