Added Combine support and updated model properties to camel case (#4) #40
Conversation
* Sync with Upstream * Updated models to use camel case instead of snake case as well as updating key decoding strategy. Added Combine support.
v0.19-rc19 This version will definitely need a tagged release considering all the breaking changes. In terms of the requested changes, those all look good. I'll commit them as soon as I'm able. |
Changes committed - let me know if you have any other comments/suggestions. |
I don't think I wanna be using pre-release versions for this package. I'm open to conversation about this, but my initial instinct is to only use final versions. |
I think that's valid. My only counter is that it shouldn't matter since versions are tagged. For instance, the Readme could point users to using 3.0.3 but we'd still have 3.1.0 (as an example) for the upcoming 0.19 release. Once 0.19 is found to be stable, we update the Readme etc. I also want to note that 0.19 is due for release fairly soon - but I understand that's a weak argument. At the end of the day, it's up to your discretion on how you'd like to handle things. |
|
I'd also like to advocate for a |
|
Since v0.19 is officially supported and all requested changes are done, can we consider merging this or would you like to test this a bit further? I updated all the models for the official v0.19 release as well. |
Sorry for the previous PR, I should have read the Readme more thoroughly.
This might be a controversial PR, but I changed the script to automatically convert properties into camel case for the Codable models since that's the normal Swift convention. All models have been updated to the latest version of the lemmy-js-client.
I also added Combine support in case others find that useful.