Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test string dependence on C library #45

Merged
merged 2 commits into from
Sep 15, 2024

Conversation

royhills
Copy link
Owner

Change test string for the invalid option test in check-error so it doesn't depend on the output from getopt_long_only() in the C library.

The Newlib based C library on cygwin gives a different output (ike-scan: unknown option) compared with glibc and BSD libc (ike-scan: unrecognized option). This was causing the check-error test to fail on Windows.

@coveralls
Copy link

coveralls commented Sep 15, 2024

Coverage Status

coverage: 76.647%. remained the same
when pulling 2fba503 on fix-check-error-on-cygwin
into d5737c9 on master.

@royhills royhills merged commit c74c01f into master Sep 15, 2024
5 checks passed
@royhills royhills deleted the fix-check-error-on-cygwin branch September 15, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants