Workaround to avoid calls to contentStream.moveTo with NaN arguments. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It works, but maybe there's a better solution
rototor
reviewed
Apr 11, 2018
| contentStream.closePath(); | ||
| break; | ||
| } | ||
| pi.next(); |
There was a problem hiding this comment.
You don't advanced the PathIterator if there is a infinite coords[0]? I Think that would cause a endless loop...
|
I'll expand this to check all parameters depending on the segment type, but this is fine for now. Do you need a release soon? |
|
And thanks for finding this bug and providing a fix for it. |
|
It's not urgent. |
rototor
added a commit
that referenced
this pull request
Apr 15, 2018
…hod, as it is JDK8+ only. Also added the JFreeChart spider example with valid and invalid data.
|
I've just released 0.14 with this fix. I changed it to check all arguments and also to compile on at least JDK 1.7. Float.isFinite() is JDK8+ ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve found a little bug in Graphics2d (always present since version 0.1).
I use this bridge to put JFreeChart into PDF.
I happened to have a JFreeChart spider chart with no data; in that case, in method walkShape (class PdfBoxGraphics2D) there are calls to contentStream.moveTo(NaN, NaN).
I propose a workaround for this issue: it works, but maybe there's a better solution