Added object params for ".by" method. #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Again, I'm not that great of a JS dev, but I think this might be a good solution for #93 |
Previously, the ".by" method could only add in increments of 1. By utilizing objects and updating the case selection, we're now able to change the increments to something customized. fixed bug in conditional and wrote a test not for dist, fails one test documented rebuilt
|
|
this can be accomplished in v3 with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the ".by" method could only add in increments of 1. By utilizing objects and updating the case selection, we're now able to change the increments to something customized.
I'm not a js expert by any means, but I think that this approach should allow for customized intervals, eg:
range.by({minutes: 30}, function(r){ something.push(r)}), thanks to the object literals allowed by MomentJS’s "add".