Make some changes for newer versions of uncrustify #1173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
mjcarroll
approved these changes
Mar 20, 2024
|
Let's wait on this one until we land ament/ament_lint#475 ; that should smooth over at least some of these differences. |
|
OK, so I ended up merging in ament/ament_lint#475 today. With that in place, as far as I can tell there are no uncrustify errors here. @ahcorde Can you confirm that, and if that is the case for you, close this PR? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uncrustify 0.78 is the new version in Ubuntu 24.04. It has some small differences in indentation compared to Uncrustify 0.72, which is what is in Ubuntu 22.04.
CI was failing https://build.ros2.org/job/Rdev__rviz__ubuntu_noble_amd64/6/#showFailuresLink