Skip to content

Commit

Permalink
Address peer review comments
Browse files Browse the repository at this point in the history
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
  • Loading branch information
hidmic committed Mar 9, 2021
1 parent 014e218 commit 74e0044
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions rosidl_adapter/rosidl_adapter/cli.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2018-2021 Open Source Robotics Foundation, Inc.
# Copyright 2018 Open Source Robotics Foundation, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand All @@ -19,6 +19,10 @@
from catkin_pkg.package import package_exists_at
from catkin_pkg.package import parse_package

from rosidl_adapter.action import convert_action_to_idl
from rosidl_adapter.msg import convert_msg_to_idl
from rosidl_adapter.srv import convert_srv_to_idl

from rosidl_cli.command.helpers import interface_path_as_tuple
from rosidl_cli.command.translate.extensions import TranslateCommandExtension

Expand Down Expand Up @@ -84,7 +88,6 @@ class TranslateMsgToIDL(TranslateToIDL):

@property
def conversion_function(self):
from rosidl_adapter.msg import convert_msg_to_idl
return convert_msg_to_idl


Expand All @@ -94,7 +97,6 @@ class TranslateSrvToIDL(TranslateToIDL):

@property
def conversion_function(self):
from rosidl_adapter.srv import convert_srv_to_idl
return convert_srv_to_idl


Expand All @@ -103,5 +105,4 @@ class TranslateActionToIDL(TranslateToIDL):

@property
def conversion_function(self):
from rosidl_adapter.action import convert_action_to_idl
return convert_action_to_idl

0 comments on commit 74e0044

Please sign in to comment.