Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for broken bag split when using cache #936

Merged
merged 3 commits into from
Dec 16, 2021
Merged

Bugfix for broken bag split when using cache #936

merged 3 commits into from
Dec 16, 2021

Commits on Dec 12, 2021

  1. Bugfix for broken bag split when using cache 

    Add `start()` method to the `CacheConsumer` class and call it from
`sequential_writer` after split.

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
    @MichaelOrlov
    MichaelOrlov committed Dec 12, 2021
    Configuration menu
    Copy the full SHA
    766cd70 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2021

  1. Adjust expectation for number of splits in SequentialCompressionWrite… 

    …rTest

writer_creates_correct_metadata_relative_filepaths since logic for split
has been changed.

Now it will be fair. If specified max_baf_file_size = 1 it will be
reasonable to expect only one message per file.

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
    @MichaelOrlov
    MichaelOrlov committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    9eb66e1 View commit details
    Browse the repository at this point in the history

  2. Fix type cast warning on Windows build 

    Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
    @MichaelOrlov
    MichaelOrlov committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    4cc7a9b View commit details
    Browse the repository at this point in the history