-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix for broken bag split when using cache #936
Conversation
Add `start()` method to the `CacheConsumer` class and call it from `sequential_writer` after split. Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
This looks like a regression to me, likely introduced with the snapshot feature. Cache consumer worked with bag splitting without the need to explicitly start it previously. This was guaranteed by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM pending green CI
rosbag2_compression/test/rosbag2_compression/test_sequential_compression_writer.cpp
Outdated
Show resolved
Hide resolved
…rTest writer_creates_correct_metadata_relative_filepaths since logic for split has been changed. Now it will be fair. If specified max_baf_file_size = 1 it will be reasonable to expect only one message per file. Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
f9bd788
to
9eb66e1
Compare
Running CI |
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Add
start()
method to theCacheConsumer
class and call it fromsequential_writer
after split. Also added unit test to cover cases when bag splitting with enabled cache.