-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate LICENSE files on ros2 pkg create. #650
Conversation
That is, if the '--license' command-line argument is one of the ones that ament_copyright knows, fetch the license text out of ament_copyright and place it in 'LICENSE' at the root of the package. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Supporting the SPDX identifier seems a little more friendly to me, since that might be what some users want to appear in the package.xml. |
I agree about the SPDX stuff. I've already seen two packages use that in their package.xml files during my ros/rosdistro cycle. |
+1 for SPDX support it will make our lives much simpler in the future for auditing |
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
All right, I've switched this over to using SPDX identifiers instead. This PR now requires ament/ament_lint#315 to go in first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just a question
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@ros-pull-request-builder retest this please |
All right, approved, CI is green. Going to merge, thanks everyone! |
That is, if the '--license' command-line argument is one of
the ones that ament_copyright knows, fetch the license text
out of ament_copyright and place it in 'LICENSE' at the
root of the package.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
Here's the current list of strings that will trigger the creation of the LICENSE file:
One thing to be aware of here is that this is the first use of
ament_copyright
in anexec_depend
. I don't think that should be a problem, but it is something to think about.An enhancement we could do here is to add the SPDX identifiers to the license tuple in ament_copyright, and then use that instead. I don't mind strongly which way we go, but we should think about it and be deliberate; changing it later on will be difficult. Feedback is most welcome.
@nuclearsandwich @tfoote @gbalke @ros2/team FYI.