-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SPDX identifiers to the licenses. #315
Conversation
This is so we can use them at a higher layer. Note that the SPDX identifier for "BSD License 2.0" is made up, since that license is also made up. We eventually need to remove it, but some of the core packages still depend on it (and really should be switched over to BSD-3-Clause). Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Could be worth adding a comment mentioning these should be SPDX identifiers? Would be useful to be explicit in case people want to add new licenses! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
The variable it gets put into is named 'spdx', which seems pretty clear to me. But maybe it is worthwhile to point to the URL where I got these; I'll add that. |
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
The only failures are in mypy, which is a known issue right now. |
Approved, and no new test failures. Going ahead and merging. |
This is so we can use them at a higher layer. Note that the
SPDX identifier for "BSD License 2.0" is made up, since that
license is also made up. We eventually need to remove it,
but some of the core packages still depend on it (and really
should be switched over to BSD-3-Clause).
Signed-off-by: Chris Lalancette clalancette@openrobotics.org