Node graph impl #251
Node graph impl #251
Conversation
|
Relates to ros2/rcl#333 |
Commit generated by ament_uncrustify --reformat
|
@ross-desmond PTAL fixed cpplint and copyright issues Only remaining cpplint issue is due to the code you copied and paste from fastrtps. Could we avoid doing that somehow? |
|
Confirmed all tests are passing now locally. |
Other headers are not included. Remove to align with the existing state of this library.
|
@ross-desmond You are currently locking a mutex twice. Hence the deadlock. I am not completely convinced this PR is OK but at least the listener / talker demo works now. |
Uncrustify and adds comments Tests pass for opensplice
|
Builds locally, passes all local tests with no errors. |
|
This patch introduced new compiler warnings on Windows. I addressed them in #252. I couldn't find any CI builds which have been run for this change (which should have shown the same warnings)? |
|
They were run for all of the node graph implementation stuff in ros2/rcl#333 , which showed all green. Do we not run Opensplice in ci_launcher? |
When you trigger the job it has several check boxes but if you don't check OpenSplice explicitly, on. OpenSplice is not a Tier 1 platform and therefore we don't test it by default in every CI build. |
Implemented node graph code here, comments are lacking and to come. However due to merge and build failures in CI, this is pushed to get initial feedback particularly on the GUID partial implementation and CI attempts.