Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated error returns on rmw_publish to comply with documentation #239

Merged
merged 2 commits into from
Sep 11, 2020
Merged

Updated error returns on rmw_publish to comply with documentation #239

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
914cd70
updated error returns on rmw_publish
Lobotuerk Sep 9, 2020
1623796
fixup! updated error returns on rmw_publish
Lobotuerk Sep 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rmw_cyclonedds_cpp/src/rmw_node.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1505,9 +1505,9 @@ extern "C" rmw_ret_t rmw_publish(
rmw_publisher_allocation_t * allocation)
{
static_cast<void>(allocation); // unused
RET_NULL(publisher);
RMW_CHECK_ARGUMENT_FOR_NULL(publisher, RMW_RET_INVALID_ARGUMENT);
RET_WRONG_IMPLID(publisher);
Lobotuerk marked this conversation as resolved.
Show resolved Hide resolved
RET_NULL(ros_message);
RMW_CHECK_ARGUMENT_FOR_NULL(ros_message, RMW_RET_INVALID_ARGUMENT);
auto pub = static_cast<CddsPublisher *>(publisher->data);
assert(pub);
if (dds_write(pub->enth, ros_message) >= 0) {
Expand Down