Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated error returns on rmw_publish to comply with documentation #239

Merged
merged 2 commits into from
Sep 11, 2020

Conversation

Lobotuerk
Copy link
Contributor

Signed-off-by: lobotuerk jtlorente@ekumenlabs.com

Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
Copy link

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with green CI.

Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green CI

@Lobotuerk
Copy link
Contributor Author

Lobotuerk commented Sep 11, 2020

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Lobotuerk Lobotuerk merged commit 2a1f8ef into master Sep 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the lobotuerk/publish_message_error_update branch September 11, 2020 19:42
ahcorde pushed a commit that referenced this pull request Oct 8, 2020
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
ahcorde pushed a commit that referenced this pull request Oct 15, 2020
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants