Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[foxy backport] Handle RMW_DEFAULT_DOMAIN_ID. (#194) #199

Merged
merged 1 commit into from
Jun 23, 2020
Merged

[foxy backport] Handle RMW_DEFAULT_DOMAIN_ID. (#194) #199

merged 1 commit into from
Jun 23, 2020

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Jun 22, 2020

No description provided.

@hidmic
Handle RMW_DEFAULT_DOMAIN_ID. (#194)
775203b 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested a review from jacobperron June 22, 2020 23:17
@hidmic hidmic changed the title Handle RMW_DEFAULT_DOMAIN_ID. (#194) [foxy backport] Handle RMW_DEFAULT_DOMAIN_ID. (#194) Jun 22, 2020
@jacobperron
Copy link
Member

I think you intended to target the foxy branch, right?

@jacobperron jacobperron changed the base branch from master to foxy June 23, 2020 05:53
eboasson
eboasson approved these changes Jun 23, 2020
View reviewed changes
Copy link
Collaborator

@eboasson eboasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hidmic
Copy link
Contributor Author

hidmic commented Jun 23, 2020

@eboasson BTW, CI jobs for MacOS and Windows have been failing on cppcheck for a good while. Seems like a configuration issue.

@hidmic
Copy link
Contributor Author

hidmic commented Jun 23, 2020

@ros-pull-request-builder retest this please

@hidmic hidmic merged commit 6598191 into foxy Jun 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the hidmic/foxy/backport-194 branch June 23, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

@eboasson eboasson eboasson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hidmic @jacobperron @eboasson