Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle RMW_DEFAULT_DOMAIN_ID. #194

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Handle RMW_DEFAULT_DOMAIN_ID. #194

merged 1 commit into from
Jun 22, 2020

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Jun 19, 2020 •
edited
Loading

Precisely what the title says. Connected to ros2/rcl#689.

@hidmic
Handle RMW_DEFAULT_DOMAIN_ID.
2d15857 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested review from wjwwood and ivanpauno June 19, 2020 20:24
@hidmic
Copy link
Contributor Author

hidmic commented Jun 19, 2020 •
edited
Loading

CI up to rcl and test_rmw_implementation against all RMW implementations:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

wjwwood
wjwwood reviewed Jun 19, 2020
View reviewed changes
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@hidmic hidmic requested a review from eboasson June 22, 2020 14:06
eboasson
eboasson approved these changes Jun 22, 2020
View reviewed changes
Copy link
Collaborator

@eboasson eboasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@hidmic hidmic merged commit c42656a into master Jun 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the hidmic/handle-default-domain-id branch June 22, 2020 15:08
hidmic added a commit that referenced this pull request Jun 22, 2020
@hidmic
Handle RMW_DEFAULT_DOMAIN_ID. (#194)
775203b 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
hidmic added a commit that referenced this pull request Jun 23, 2020
@hidmic
Handle RMW_DEFAULT_DOMAIN_ID. (#194) (#199)
6598191 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood left review comments

@eboasson eboasson eboasson approved these changes

@ivanpauno ivanpauno Awaiting requested review from ivanpauno ivanpauno is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hidmic @wjwwood @eboasson