Remove connext workaround

[mikaelarguedas]

From what I understand this was only necessary for Ubuntu connext builds with gcc4.8.2 (https://community.rti.com/static/documentation/connext-dds/5.3.0/doc/manuals/connext_dds/RTI_ConnextDDS_CoreLibraries_PlatformNotes.pdf).
As we now target connext 5.3.0 that is built with gcc5.4 this doesnt apply anymore.

I don't have the full context, relevant discussion: ros2/rcl#55 (comment)

If we decide to keep it it may make sense to export these flags (#178 (comment)) to avoid workarounds in downstream packages

• Linux Debug

• Linux Release

Edit: New ci:

• Linux Debug

• Linux Release

[mikaelarguedas]

CI is happy, ready for review

[dhood]

this seems safe to remove now

I have some additional context since I was involved in the issue/PRs at the time, so I'll dump it here for the future (you were probably already aware of it all @mikaelarguedas it's just for general knowledge)

As we now target connext 5.3.0 that is built with gcc5.4 this doesnt apply anymore.

Assuming they fixed the issue moving forwards.. if CI passes without the workaround now then I suppose so 😄 At the time the issue (ros2/rcl#52) was only when using binaries off their website (not the debs we built ourselves), and now we use website binaries in our CI, so if it works for us it should work for everyone.

If we decide to keep it it may make sense to export these flags to avoid workarounds in downstream packages

Though it looks like it from ros2/rcl#55, workarounds aren't necessary in downstream packages since #188 (#173 was superseded by #188). The workaround in ros2/rcl#55 was just done before it, and probably could have been removed afterwards.

[mikaelarguedas]

Thanks for the summary, it's good to have confirmation as I tried to follow these various connected issues but wasn't sure I got all the context.