This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Use --no-as-needed in abi check #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,3 +21,4 @@ include_directories(@Connext_INCLUDE_DIRS@) | |||
| add_executable(exe | |||
| "@connext_cmake_module_DIR@/check_abi.cpp") | |||
| target_link_libraries(exe @Connext_LIBRARIES@) | |||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wl,--no-as-needed") | |||
There was a problem hiding this comment.
Please append the new flags to the already existing line 17.
dhood
force-pushed
the
use_no_as_needed_abi_check
branch
from
1158ab8
to
6669689
Compare
dhood
added
in review
|
+1 |
dhood
force-pushed
the
use_no_as_needed_abi_check
branch
from
6669689
to
343adc2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can be changed to
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} @Connext_LINK_FLAGS@")after #173 is mergedconnects to ros2/rcl#66