Initialize QoSProfile with values from rmw_qos_profile_default #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tch behavior from rclcpp Signed-off-by: Emerson Knapp <eknapp@amazon.com>
|
@thomas-moulard - please run this CI job |
|
nburek
reviewed
May 22, 2019
added 2 commits
May 22, 2019 10:42
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
nburek
approved these changes
May 22, 2019
added 2 commits
May 23, 2019 11:50
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
jacobperron
approved these changes
May 23, 2019
Edit: RViz test failures can't be related since there's no connection to rclpy. |
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match behavior in rclcpp.
Fixes #353
Would like some feedback on the approach, it feels a little kludgy. It's an awkward situation though, where the default profile values we want are only exposed via a QoSProfile instance from _rclpy.c, so we have a circular dependency.
Signed-off-by: Emerson Knapp eknapp@amazon.com