Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install the rest of the flake8 plugins via dnf. #790

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

clalancette
Copy link
Contributor

These are available from EPEL now, so we can install them from packages rather than pip.

These are available from EPEL now, so we can install them
from packages rather than pip.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Copy link
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@cottsay
Copy link
Member

cottsay commented Oct 8, 2024

Should we add these to the ros-dev-tools metapackage, or are they included as proper dependencies of one of the ROS packages?

@clalancette
Copy link
Contributor Author

Should we add these to the ros-dev-tools metapackage, or are they included as proper dependencies of one of the ROS packages?

See ament/ament_lint#503 , which makes them proper dependencies.

@clalancette clalancette merged commit 2cdfab2 into master Oct 9, 2024
1 check passed
@clalancette clalancette deleted the clalancette/rhel-flake8-plugins branch October 9, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants