Add the rest of the flake8 plugins as dependencies. #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are now all available on Ubuntu and RHEL, and they are in rosdep, so we can make them true dependencies now. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
Pulls: #503
|
cottsay
approved these changes
Oct 8, 2024
|
Note that ros2ci jobs don't care about rosdep changes in The PR job, however, reports successful resolution and installation of the new dependencies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are now all available on Ubuntu and RHEL, and they are in rosdep, so we can make them true dependencies now.
Once this is approved, passes CI, and merged, I'll do a release right away to get this into Rolling.