Fix missing Dockerfile ARG, Update Rust to 1.49.0 #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker ARG REPOS_FILE was not redeclared in the "cacher" build stage, and so was not inheriting the default value specified at the top of the file. This redeclares the arg in the "cacher" build stage, so that the default value may be used.
rclrs_examples fail to compile due to the following error ``` error[E0658]: use of unstable library feature 'renamed_spin_loop' --> /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/spin-0.9.2/src/relax.rs:26:9 | 26 | core::hint::spin_loop(); | ^^^^^^^^^^^^^^^^^^^^^ | = note: see issue #55002 <rust-lang/rust#55002> for more information Compiling bitvec v0.19.5 error: aborting due to previous error ``` As seen in the noted link, updating Rust can resolve the issue. This updates Rust in the Dockerfile to 1.49.0, where the issue seems to be resolved.
christopherjreid
changed the title
esteve
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker ARG REPOS_FILE was not redeclared in the "cacher" build stage,
and so was not inheriting the default value specified at the top of the
file. This redeclares the arg in the "cacher" build stage, so that the
default value may be used.
On the specified version of Rust in the Dockerfile (1.47.0), a build error was encountered in rclrs_examples
As seen at the given link, updating Rust resolves the issue. 1.48.0 also had build failures, but 1.49.0 passed.