Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python3-pyqt6.qtmultimedia #41977

Merged
merged 5 commits into from
Jul 31, 2024
Merged

Add python3-pyqt6.qtmultimedia #41977

merged 5 commits into from
Jul 31, 2024

Conversation

NoahMollerstuen
Copy link
Contributor

Please add the following dependency to the rosdep database.

Package name:

python3-pyqt6.qtmultimedia

Package Upstream Source:

https://pypi.org/project/PyQt6/

Purpose of using this:

Used for working with audio and video in GUI applications

Distro packaging links:

Links to Distribution Packages

@NoahMollerstuen NoahMollerstuen requested a review from a team as a code owner July 5, 2024 22:33
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label Jul 5, 2024
@marcoag marcoag self-assigned this Jul 10, 2024
@marcoag marcoag added the changes requested Maintainers have asked for changes to the pull request label Jul 10, 2024
rosdep/python.yaml Outdated Show resolved Hide resolved
@Yadunund
Copy link
Member

@NoahMollerstuen could you address the git conflict?

NoahMollerstuen and others added 2 commits July 11, 2024 09:58
Co-authored-by: Marco A. Gutierrez <marcogg@marcogg.com>
@NoahMollerstuen
Copy link
Contributor Author

@NoahMollerstuen could you address the git conflict?

Done!

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides what I put inline, this needs to be rebased for unrelated reasons. All of that should fix CI.

rosdep/python.yaml Outdated Show resolved Hide resolved
NoahMollerstuen and others added 2 commits July 25, 2024 18:25
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
@clalancette clalancette removed the changes requested Maintainers have asked for changes to the pull request label Jul 29, 2024
@sloretz sloretz dismissed marcoag’s stale review July 31, 2024 01:52

changes since review

@sloretz sloretz merged commit 0bfa5bb into ros:master Jul 31, 2024
4 checks passed
@NoahMollerstuen NoahMollerstuen deleted the patch-1 branch July 31, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants