Fix #879

[goretkin]

Sorry to pull against groovy. Should forward-port cleanly.

[wjwwood]

#879

[130s]

I tried this PR on Indigo by just rebasing to origin/indigo-devel, and I still see the same issue happening unfortunately.

[130s]

[goretkin]

Can you confirm that you're running the recompiled binary? by doing
something like adding a print statement.
On May 31, 2015 7:03 PM, "Isaac I.Y. Saito" notifications@github.com
wrote:

[image: rviz_wrench_off_gorekin]
https://cloud.githubusercontent.com/assets/1840401/7904417/7393bd9e-07ae-11e5-8e89-468f5954bb66.png

—
Reply to this email directly or view it on GitHub
#883 (comment)
.

[130s]

@goretkin yeah, I removed rviz by sudo apt-get remove ros-indigo-rviz and rospack find rviz points to the source directory.

[goretkin]

I suppose I can only confirm the fix on groovy (it works for me), but it does seem bizarre that it's not working for you on Indigo.

Could you try to change the line

Ogre::Quaternion orientation = axis_z.getRotationTo(torque);

to

Ogre::Quaternion orientation = axis_z.getRotationTo(axis_z);

This should make the orientation of the torque circle marker be at a fixed orientation. For example the yellow and purple arrows below are torque vectors, but their circular markers are oriented in a fixed way.

[130s]

+1

It seems to be working on my Indigo as well. I just had to uninstall RViz deb.

[goretkin]

@130s, sorry I don't understand. What is working? What do those screenshots correspond to?

[130s]

Sorry my last post wasn't clear.

Your pull request works on my Indigo, without any additional modification that you suggested.
Earlier I reported that your PR still didn't solve the issue, which turned out that I was still referencing to the RViz installed via apt.

[goretkin]

@130s , I'm glad to hear it. The "additional modification" was not a fix, but was a confirmation that you were actually running the RViz you compiled. Looks like you weren't, but you figured it out another way.

The screenshots you included, just to confirm, show the broken behavior, right?

[wjwwood]

Ok, I'll merge and then forward port this to hydro and indigo/jade.

[wjwwood]

Hydro forward port: #902

[wjwwood]

Indigo forward port: #903

[goretkin]

Thanks!
On Aug 5, 2015 1:38 PM, "William Woodall" notifications@github.com wrote:

Indigo forward port: #903
#903

—
Reply to this email directly or view it on GitHub
#883 (comment)
.