Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rolling] image_publisher: Fix image, constantly flipping when static image is published (backport #986) #989

Merged
merged 1 commit into from
May 27, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented May 27, 2024

Continuation of #984.

When publishing video stream from a camera, the image was flipped correctly. Yet for a static image, which was loaded once, the flip function was applied every time ImagePublisher::doWork() was called, resulting in the published image being flipped back and forth all the time.

This PR should be straightforward to port it to Humble, Iron and Jazzy.


This is an automatic backport of pull request #986 done by Mergify.

… image is published (#986)

Continuation of
#984.

When publishing video stream from a camera, the image was flipped
correctly. Yet for a static image, which was loaded once, the flip
function was applied every time `ImagePublisher::doWork()` was called,
resulting in the published image being flipped back and forth all the
time.

This PR should be straightforward to port it to `Humble`, `Iron` and
`Jazzy`.

(cherry picked from commit 7f25ec9)
@ahcorde ahcorde merged commit 793ee56 into iron May 27, 2024
3 checks passed
@ahcorde ahcorde deleted the mergify/bp/iron/pr-986 branch May 27, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants