Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression in RHEL 8 / Python3.6 support. #700

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Fix regression in RHEL 8 / Python3.6 support. #700

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d407d7
check for python version to handle method signature change in argparse
ijnek Apr 6, 2023
df15cb4
Update bloom/commands/generate.py
ijnek May 26, 2023
6daa1d5
Fix indentation level.
nuclearsandwich May 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions bloom/commands/generate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,15 @@ def load_generator_description(generator_name):

def create_subparsers(parser, generator_cmds):
metavar = '[' + ' | '.join(generator_cmds) + ']'
subparsers = parser.add_subparsers(
title='generate commands',
metavar=metavar,
description='Call `bloom-generate {0} -h` for help on a each generate command.'.format(metavar),
dest='generator_cmd',
required=True
)
subparsers_kwargs = {
'title': 'generate commands',
'metavar': metavar,
'description': 'Call `bloom-generate {0} -h` for help on a each generate command.'.format(metavar),
'dest': 'generator_cmd'
}
if sys.version_info >= (3, 7):
subparsers_kwargs['required'] = True
subparsers = parser.add_subparsers(**subparsers_kwargs)
for generator_cmd in generator_cmds:
desc = load_generator_description(generator_cmd)
cmd_parser = subparsers.add_parser(desc['title'], description=desc['description'])
Expand Down