Merge pull request j5int#9 from stevehof/master

Hide inAppBrowser dialog instead of closing
rorygrandin · Jul 9, 2019 · 2696279 · 2696279
2 parents 2c240f1 + ca54ee8
commit 2696279
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "cordova-plugin-inappbrowser",
-  "version": "3.0.0-j5.2",
+  "version": "3.0.0-j5.3",
   "description": "Cordova InAppBrowser Plugin",
   "types": "./types/index.d.ts",
   "cordova": {

diff --git a/plugin.xml b/plugin.xml
@@ -20,7 +20,7 @@
 
 <plugin xmlns="http://apache.org/cordova/ns/plugins/1.0"
            id="cordova-plugin-inappbrowser"
-      version="3.0.0-j5.2">
+      version="3.0.0-j5.3">
 
     <name>InAppBrowser</name>
     <description>Cordova InAppBrowser Plugin</description>

diff --git a/src/android/InAppBrowser.java b/src/android/InAppBrowser.java
@@ -710,7 +710,7 @@ public void run() {
                 dialog.getWindow().getAttributes().windowAnimations = android.R.style.Animation_Dialog;
                 dialog.requestWindowFeature(Window.FEATURE_NO_TITLE);
                 dialog.setCancelable(true);
-                dialog.setInAppBroswer(getInAppBrowser());
+                dialog.setInAppBrowser(getInAppBrowser());
 
                 // Main container layout
                 LinearLayout main = new LinearLayout(cordova.getActivity());

diff --git a/src/android/InAppBrowserDialog.java b/src/android/InAppBrowserDialog.java
@@ -37,7 +37,7 @@ public InAppBrowserDialog(Context context, int theme) {
         this.context = context;
     }
 
-    public void setInAppBroswer(InAppBrowser browser) {
+    public void setInAppBrowser(InAppBrowser browser) {
         this.inAppBrowser = browser;
     }
 
@@ -49,8 +49,8 @@ public void onBackPressed () {
             // because it does a clean up
             if (this.inAppBrowser.hardwareBack() && this.inAppBrowser.canGoBack()) {
                 this.inAppBrowser.goBack();
-            }  else {
-                this.inAppBrowser.closeDialog();
+            }else{
+                this.hide();
             }
         }
     }

diff --git a/tests/plugin.xml b/tests/plugin.xml
@@ -20,7 +20,7 @@
 
 <plugin xmlns="http://apache.org/cordova/ns/plugins/1.0"
     id="cordova-plugin-inappbrowser-tests"
-    version="3.0.0-j5.2">
+    version="3.0.0-j5.3">
     <name>Cordova InAppBrowser Plugin Tests</name>
     <license>Apache 2.0</license>